Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Allow building images on NFS-mounted clones #11

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Allow building images on NFS-mounted clones #11

merged 1 commit into from
Jul 10, 2019

Conversation

nirenjan
Copy link

@nirenjan nirenjan commented Jul 9, 2019

Prior to this change, build_debian.sh would generate a Debian filesystem in ./fsroot. This needs root permissions, and one of the tests that is performed is whether the user can create a character special file in the filesystem (using mknod).

On most NFS deployments, root is the least privileged user, and cannot run mknod. Also, attempting to run commands like rm or mv as root would fail due to permission errors, since the root user gets mapped to an unprivileged user like nobody.

This commit changes the location of the Debian filesystem to /fsroot, which is a tmpfs mount within the slave Docker. The default squashfs, docker tarball and zip files are also created within /tmp, before being copied back to /sonic as the regular user.

The side effect of this change is that the contents of /fsroot are no longer available once the slave container exits, however they are available within the squashfs image.

@nirenjan
Allow building images on NFS-mounted clones
de36781 
Prior to this change, `build_debian.sh` would generate a Debian
filesystem in `./fsroot`. This needs root permissions, and one of the
tests that is performed is whether the user can create a character
special file in the filesystem (using mknod).

On most NFS deployments, `root` is the least privileged user, and cannot
run mknod. Also, attempting to run commands like rm or mv as root would
fail due to permission errors, since the root user gets mapped to an
unprivileged user like `nobody`.

This commit changes the location of the Debian filesystem to `/fsroot`,
which is a tmpfs mount within the slave Docker. The default squashfs,
docker tarball and zip files are also created within /tmp, before being
copied back to /sonic as the regular user.

The side effect of this change is that the contents of `/fsroot` are no
longer available once the slave container exits, however they are
available within the squashfs image.

Signed-off-by: Nirenjan Krishnan <Nirenjan.Krishnan@dell.com>
@nirenjan
Copy link
Author

nirenjan commented Jul 9, 2019

@PrabhuSreenivasan, can you review the changes and comment please?

@srideepDell
Copy link

installer was build and was booting fine ?
does this impact building for any other ABOOT systems ?

@PrabhuSreenivasan PrabhuSreenivasan merged commit f17c27f into master Jul 10, 2019
seiferteric pushed a commit that referenced this pull request Nov 25, 2019
@anand-kumar-subramanian
Update git submodules
2e950a7 
* Update src/sonic-telemetry from branch 'broadcom_sonic'
  to 31c54a162e0707830cefcad5cf99451c293095f4
  - [JIRA SONIC-10470]merge sonic-telemetry dell_sonic --> broadcom_sonic 11112019
    
    Change-Id: I2ae9fe6f9a60937ad178c3a930308ea046cad51e
    
  - Merge pull request sonic-net#43 from project-arlo/gnoi_ConfigManagement
    
    Add config mgmt gNOI RPCs, rename sonic gNOI proto file
  - Merge pull request sonic-net#42 from project-arlo/gnoi_techsupport
    
    Gnoi techsupport
  - Add config mgmt gNOI RPCs, rename sonic gNOI proto file
    
  - Merge remote-tracking branch 'github/master' into gnoi_techsupport
    
  - Merge pull request sonic-net#41 from project-arlo/gnmi_set_prefix
    
    Add prefix support to gnmi_set
  - Merge pull request sonic-net#40 from project-arlo/updates_only
    
    Updates only
  - Merge pull request sonic-net#39 from project-arlo/username_password_support
    
    Username password support
  - Make same changes for show-techsupport proto
    
  - Add sonic-tests:sum rpc for example
    
  - wip
    
  - Initial support for showTechSupport rpc
    
  - Add prefix support to gnmi_set
    
  - Finish updates_only for poll and once
    
  - Move line inside block
    
  - Implement updates_only for stream subscriptions
    
  - Add authentication to gNOI. Return gRPC erros from PAMAuthenAndAuthor for better error codes
    
  - verify username/password is actually sent
    
  - Remove file added by accident
    
  - Add cmd line arg to enable user/passwd auth
    
  - Initial username/password auth support
    
  - Merge pull request #36 from project-arlo/gNOI
    
    Initial gNOI Support
  - Merge pull request #37 from project-arlo/jsonSchemaTests
    
    Json schema tests
  - remove debug code
    
  - Fix bug with muliple operations reusing path var
    
  - Add target option to gNOI client
    
  - Get schema for tests from compiled output
    
  - Add flag module to gNOI client to support morre rpcs in the future
    
  - Remove commented out code
    
  - Initial checkin for gNOI, with example System Time rpc
    
  - Merge pull request #34 from project-arlo/jsonSchemaTests
    
    Json schema tests
  - Merge pull request #35 from project-arlo/brcm_poc
    
    Brcm poc
  - Merge remote-tracking branch 'broadcom/broadcom_sonic' into brcm_poc
    
  - Add cleanup to test cases
    
  - Migrate interface ipv4 test to new format
    
  - Fix Makefile schema path, ad models, change test format
    
  - Fix formatting of json in README
    
  - Merge pull request #33 from project-arlo/master
    
    Syncing project-arlo/sonic-telmetry master to brcm_poc
  - typo
    
  - Add readme for json schema tests
    
  - More changes for Json Schema based tests
    
  - Use json schema for get tests as well. Use get test in set to verify results
    
  - Go back to local gNMI server
    
  - Initial validation support using json schema
    
  - Load tests from files and get info from file name
    
  - Merge pull request #30 from project-arlo/fix-check-testcase
    
    Fix check testcase to check individual attributes in a platform-independent way.
  - Merge pull request #31 from project-arlo/gnmi_cli_fixes
    
    Add check that heartbeat_interval is only valid on streaming query type
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: Ia772a55a893c2bee3c9e974700e4821f2f8d7af6
    
  - Add check that heartbeat_interval is only valid on streaming query type
    
  - Merge branch 'master' of https://github.com/project-arlo/sonic-telemetry into fix-check-testcase
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #29 from project-arlo/master
    
    Dell fixes on telemetry repo - 13th Sep
  - Merge pull request #28 from project-arlo/tests
    
    Disable platform specific test for now
  - Disable platform specific test for now
    
  - Merge pull request #27 from project-arlo/update_tls_config
    
    Remove duplicate ciphers
  - Remove duplicate ciphers
    
  - fix the check if value set testcase
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #26 from project-arlo/update_tls_config
    
    Update tls config
  - Update cipher suite list again
    
  - Fix spaces to tabs
    
  - Set Min TLS Version and cipher suites
    
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: Iae02e417fe8c8ea378a0e85d2354cda10f833b1b
    
  - Merge pull request #25 from project-arlo/master
    
    merge gnmi_cli code into telemetry repo
  - Merge pull request #23 from project-arlo/gnmi_cli_fixes
    
    Gnmi cli fixes
  - Merge pull request #24 from project-arlo/brcm_poc
    
    Fix low code coverage issue by enabling the gnmi_server test code listening on port 8081
  - Fix streaming_type in tests
    
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: I14fb29ab4016f390fab9c930a0af69f9a20eba85
    
  - Merge remote-tracking branch 'sshorigin/master' into gnmi_cli_fixes
    
  - Add full code for gnmi_cli with our changes so it can be built from scratch like gnmi_set/get. Update Makefile. Add fixes to gnmi_cli to use seconds as units everywhere instead of nanoseconds, and accept string for -streaming_type
    
  - Merge pull request #22 from project-arlo/brcm_poc
    
    BRCM changes for Telemetry UT
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: I4a0804425a4e0a396870004d717f192354dd19c8
    
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: Id9f1bef203c4a017d53ce0a854072732656e69ee
    
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: Id9f1bef203c4a017d53ce0a854072732656e69ee
    
  - Merge pull request #21 from project-arlo/master
    
    bring brcm_poc in par with master
  - Merge pull request #20 from project-arlo/gnmi-test-after-set
    
    Add code to check values set
  - Add code to check values set
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #19 from project-arlo/gnmi-add-delete-test
    
    Minor fix in Delete OC Interface IP testcase
  - Minor fix in Delete OC Interface IP testcase
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #18 from project-arlo/gnmi-add-delete-test
    
    Add delete test case
  - Add delete testcase
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #17 from project-arlo/gnmi_test_sys_pfm
    
    Gnmi Server test for system platform and interfaces
  - Add json file for ip config
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  -  Working gnmi server test for sys,pfm,interfaces
    
  - Add test to set ip address
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Code cleanup in server_test.go
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Fix paths
    
  - fix
    
  - Fix some issues with test infra
    
  - Changes for testing get/set operations on OC interfaces
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - working gnmi sys and pfm test without clearing bad logs
    
  - Merge pull request #16 from project-arlo/tests
    
    Disable old tests that fail due to new fields being added. Add basic …
  - Disable old tests that fail due to new fields being added. Add basic interface get test and capabilities test. Change package name and add symlink to cvl schema
    
  - Merge pull request #15 from project-arlo/tests
    
    Add test directory
  - Add test directory
    
  - Merge pull request #14 from project-arlo/translib-stream-subscribe
    
    Implement updates_only for ON_CHANGE streaming mode
  - Implement updates_only for ON_CHANGE streaming mode
    
  - Merge pull request #13 from project-arlo/translib-stream-subscribe
    
    Check error response before adding to on_change list
  - Check error response before adding to on_change list
    
  - Merge pull request #12 from project-arlo/capabilities-models
    
    Return models based on translib GetModels API
  - Return models based on translib GetModels API
    
  - Merge pull request #11 from project-arlo/translib-stream-subscribe
    
    Translib stream subscribe
  - Fix bug with sync messages
    
  - Implement suppress_redundant, fix ticker_map format, remove some debug prints, fix heartbeats
    
  - Close channel on error, check if timer if HB
    
  - Update IsSupported to IsOnChangeSupported, add heartbeat_interval support to gnmi_cli, remove debug code
    
  - Fix issue with when sync message is sent. Add heartbeat support. Add valueCache for suppress_redundant (wip)
    
  - convert subscribeResponse to gnmi subscribeResponse and return
    
  - wip
    
  - Merge pull request #10 from project-arlo/fix-if-replace-update
    
    Fix issue with updates and replace with interfaces
  - Fix issue with updates and replace with interfaces
    
  - Merge pull request #9 from project-arlo/sample-subscribe
    
    Sample subscribe
  - Fixes, also include binary for gnmi_cli for now
    
  - Add some dummy code for future subscribe api
    
  - cleanup
    
  - Use ticker_info struct
    
  - cleanup
    
  - Add paths to existing timer group if interval is the same
    
  - Initial support for sample based streaming subscribe
    
  - Merge pull request #8 from project-arlo/subscribe-support
    
    Ad once channel cleanup
  - Ad once channel cleanup
    
  - Merge pull request #7 from project-arlo/subscribe-support
    
    Subscribe support
  - Add gnmi_cli for subscribe client, update Makefile to build it, add .gitignore
    
  - Implement ONCE subscribe mode for translib
    
  - Port polling subscriptions code for translib
    
  - Merge pull request #6 from project-arlo/buildimage-refactor
    
    Fix build issue
  - Fix build issue
    
  - Merge pull request #5 from project-arlo/buildimage-refactor
    
    trigger building ocbinds file in translib, add gnmi_clients
  - trigger building ocbinds file in translib, forgot to add gnmi_clients in last commit
    
  - Merge pull request #4 from project-arlo/buildimage-refactor
    
    Add gnmi set and get client to build
  - Add gnmi set and get client to build
    
  - Merge pull request #3 from project-arlo/buildimage-refactor
    
    Add back install and other targets to fix deb package
  - Add back install and other targets to fix deb package
    
  - Merge pull request #2 from project-arlo/buildimage-refactor
    
    Buildimage refactor
  - Install CVL deps and update gopath
    
  - More Makefile changes
    
  - Move source files into src, change import paths, fixing Makefile
    
  - Merge pull request #1 from project-arlo/brcm_poc
    
    Merge PoC changes to master
  - Ignore test results for gnmi_server
    
    The Debian files attempt to run make check for the gNMI server, however,
    it fails on a build machine, because it expects the Redis server to be
    available and listening on localhost port 6379.
    
    For now, the result of the test is ignored, and we have to find a way to
    fix this so that the tests work even on a build machine.
    
  - GNMI PoC changes
seiferteric pushed a commit that referenced this pull request Nov 5, 2020
@jleveque
[sonic-telemetry][sonic-mgmt-common] Update submodules (sonic-net#4986)
2890670 
* src/sonic-telemetry fa8d498...3bd7ca3 (4):
  > Update gnmi deps (sonic-net#40)
  > [testdata] Update SFP keys to align with new standard (sonic-net#39)
  > Fixed the parameters for subscribe APIs (sonic-net#38)
  > Azure ro mode (#34)

* src/sonic-mgmt-common 444aa9a...cc01ce4 (4):
  > Make gnmi dep version the same as in telemetry repo (#17)
  > Cleanup translib and cvl go test cases (#13)
  > Package update and enhancements/fixes in YGOT, and Request Binder (#12)
  > Translib phase I changes (#11)

Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch
seiferteric pushed a commit that referenced this pull request Jan 24, 2022
@KostiantynYarovyiBf @VadymYashchenko
@dmytroxIntel @vboykox @bratashX @mykolaxgerasymenko
[BFN] Updated platform plugins (sonic-net#9540)
4037867 
* [BFN] Updated platform APIs impl

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Extended BFN platform SFP APIs implementation

* Update sfp.py

* [BFN] Extended SFP platform plugin implementation

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [BFN] Extended Fans platform plugin implementation

* [BFN] divided classes Fan and  FanDrawer into 2 files

* Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

What I did
	Add get_model() function
	Add get_low_critical_threshold() function
	Change __get(...) function.
How I did it
	Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API

* Add get_presence() function and revised __get() function

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

* [BFN] Updated PSU platform APIs impl

Signed-off-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com>

* Added BFN PSU cache (#9)

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [BFN]  Fans and Fantray platform APIs update (#7)

* [BFN] Updated SFP platform APIs (#10)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* [BFN] Updated platform API for thermal (#8)

* Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

* Revert "[BFN]  Fans and Fantray platform APIs update (#7)" (#11)

This reverts commit c62a733.

* Add support health monitor system (#15)

Signed-off-by: Petro Bratash <petrox.bratash@intel.com>

* Update chassis.py

* [BFN] Updated FANs and FAN Tray platform API (#14)

* Fix fix_alignment (#17)

Signed-off-by: Petro Bratash <petrox.bratash@intel.com>

* [BFN] Improvement show environment (#16)

* Added PSU temperature skip into platform.json (#18)

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Do not skip psud on Newport

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [BFN] fix fan status from Not OK to Ok (#19)

* [BFN] Updated SFP platform plugin (#13)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21)

Signed-off-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>

* [barefoot] Tmp fix vendor_rev (#22)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* Fixed python issues in sonic_platform/fan_drawer.py

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Updated fan_drawer.py

* Fixing trailing white spaces in fan_drawer.py

* [BFN] Fix thrift for SFPs API

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [Newport] Thermal manager  (#23)

* Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

* Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue"

This reverts commit 1e73127.

* Removed 'controllable' options from platform.json to fix factory default config generation

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Update thermal_manager.py

* Migrated SFP plugin to sonic_xcvr API (#30)

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

Co-authored-by: KostiantynYarovyiBf <kostiantynx.yarovyi@intel.com>
Co-authored-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>
Co-authored-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com>
Co-authored-by: Volodymyr Boiko <volodymyrx.boiko@intel.com>
Co-authored-by: Petro Bratash <petrox.bratash@intel.com>
Co-authored-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>
seiferteric pushed a commit that referenced this pull request Jan 24, 2022
@zjswhhh
[sonic-linkmgrd][master] submodule update sonic-net#9808
22e4b9b 
[sonic-linkmgrd][master] submodule update

Commits added:
0c23756 Jing Zhang      2022-01-19      Linkmgrd subscribing State DB route event  (#13)
12b9951 Longxiang Lyu   2021-12-13      Add TLV support to ICMP payload (#11)
3eedda3 Longxiang Lyu   2022-01-06      Add missing intermediate states (#16)
8da4982 Ying Xie        2022-01-04      [linkmgrd] update README, set coding style guidance (#15)
a897cf8 Longxiang Lyu   2021-12-13      Improve PR template (#16)
6fec701 Jing Zhang      2021-12-06      Add pull request template for linkmgrd repo (#9)


signed-off-by: Jing Zhang zhangjing@microsoft.com
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seiferteric seiferteric seiferteric approved these changes

Assignees

@seiferteric seiferteric

@jghalam jghalam

@srideepDell srideepDell

@jeff-yin jeff-yin

@PrabhuSreenivasan PrabhuSreenivasan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirenjan @srideepDell @seiferteric @jghalam @jeff-yin @PrabhuSreenivasan